TF-905: Bump versions of Electron, Node and capnp #13
Conversation
arunas-cesonis
requested review from
a team and
mwilliamson-fourier
and removed request for
a team
Have only tested on Linux thus far |
|
@mwilliamson-fourier Windows binary updated in f6833a1 |
There was a problem hiding this comment.
This seems good to me! It might just be worth being explicit in the pull request / commit description about the testing that's been done, for instance that we've tested across the four platforms that we run this module on using an updated version of Electron, and overall performance is improved.
I don't think my testing has shown that the performance of this module has improved! |
I thought overall performance (of the application) had improved using the new version of Electron, including the new version of this module? |
Sorry, didn't understand your comment fully. I still think we do not have knowledge of what are the changes in performance in this module, but updated the description to include my findings! |
Bumps versions of Electron (from 20.3.3 to 35.1.2) and capnp (from 0.10.3 to 1.1.0) to allow using this library in newer Electron versions.
Tested by replacing previous version in a project that makes heavy use of this on Windows, Apple arm64 and x64.
The specific project that this change was tested on has shown a noticeable overall performance improvement on all platforms when moving from Electron 20.3.3 to 35.1.2 which may mean that any performance degradation (if any) due to extra allocation and memcpy introduced in this change should be negligible.